Fix double-slash when basePath is root #17841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
commented
Sep 3, 2025
Comment on lines
-244
to
+212
| Assert.isTrue(!basePath.endsWith("/"), "basePath must not end with a slash"); | ||
| Assert.isTrue("/".equals(basePath) || !basePath.endsWith("/"), "basePath must not end with a slash"); |
There was a problem hiding this comment.
I believe in gh-17812, it was proposed to allow passing basePath as “/”.
|
I think the build crashes because of 0a991a9 |
Closes spring-projectsgh-17812 Signed-off-by: Andrey Litvitski <[email protected]>
jzheaux
added
in: web
|
Thanks, @therepanic! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: gh-17812